feat: remove workflow-name org scoping (#1414)

Signed-off-by: Miguel Martinez <[email protected]>

Author: migmartri

app/cli/cmd/attestation_init.go

@@ -107,6 +107,9 @@ func newAttestationInitCmd() *cobra.Command {
 	cobra.CheckErr(cmd.Flags().MarkDeprecated("name", "please use --workflow instead"))
 	cmd.Flags().StringVar(&workflowName, "workflow-name", "", "name of the workflow to run the attestation")
 	cobra.CheckErr(cmd.Flags().MarkDeprecated("workflow-name", "please use --workflow instead"))
+
 	cmd.Flags().StringVar(&projectName, "project", "", "name of the project of this workflow")
+	cobra.CheckErr(cmd.MarkFlagRequired("project"))
+
 	return cmd
 }

app/controlplane/api/controlplane/v1/workflow_run.pb.go

@@ -87,8 +87,7 @@ message AttestationServiceGetPolicyGroupResponse {
 message AttestationServiceGetContractRequest {
   int32 contract_revision = 1;
   string workflow_name = 2 [(buf.validate.field).string.min_len = 1];
-  // optional for now for compatibility with the CLI
-  string project_name = 3;
+  string project_name = 3 [(buf.validate.field).string.min_len = 1];
 }
 
 message AttestationServiceGetContractResponse {
@@ -104,9 +103,8 @@ message AttestationServiceInitRequest {
   int32 contract_revision = 1;
   string job_url = 2;
   workflowcontract.v1.CraftingSchema.Runner.RunnerType runner = 3;
-  string workflow_name = 4;
-  // optional for now for compatibility with the CLI
-  string project_name = 5;
+  string workflow_name = 4 [(buf.validate.field).string.min_len = 1];
+  string project_name = 5 [(buf.validate.field).string.min_len = 1];
 }
 
 message AttestationServiceInitResponse {

app/controlplane/api/controlplane/v1/workflow_run.proto

@@ -221,11 +221,11 @@ func (s *dispatcherTestSuite) SetupTest() {
 	assert.NoError(s.T(), err)
 
 	// Workflow
-	s.workflow, err = s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow", OrgID: s.org.ID})
+	s.workflow, err = s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow", OrgID: s.org.ID, Project: "test-project"})
 	assert.NoError(s.T(), err)
 
 	// Workflow
-	s.emptyWorkflow, err = s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "empty-workflow", OrgID: s.org.ID})
+	s.emptyWorkflow, err = s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "empty-workflow", OrgID: s.org.ID, Project: "test-project"})
 	assert.NoError(s.T(), err)
 
 	customImplementation := mockedSDK.NewFanOutPlugin(s.T())

app/controlplane/api/gen/frontend/controlplane/v1/workflow_run.ts

@@ -353,10 +353,10 @@ func (s *casMappingIntegrationSuite) SetupTest() {
 
 	// Create workflowRun in the database
 	// Workflow
-	workflow, err := s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow", OrgID: s.org1.ID})
+	workflow, err := s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow", OrgID: s.org1.ID, Project: "test-project"})
 	assert.NoError(err)
 
-	publicWorkflow, err := s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow-public", OrgID: s.org1.ID, Public: true})
+	publicWorkflow, err := s.Workflow.Create(ctx, &biz.WorkflowCreateOpts{Name: "test-workflow-public", OrgID: s.org1.ID, Public: true, Project: "test-project"})
 	assert.NoError(err)
 
 	// Find contract revision