feat: remove workflow-name org scoping #1414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Martinez <[email protected]>
Signed-off-by: Miguel Martinez <[email protected]>
migmartri
changed the title
javirln
approved these changes
Oct 21, 2024
| @@ -0,0 +1,2 @@ | |||
| -- Modify "workflows" table | |||
| ALTER TABLE "workflows" ALTER COLUMN "project" SET NOT NULL; | |||
There was a problem hiding this comment.
We don't need a migration of previous workflows right?
There was a problem hiding this comment.
No because they happened to be set and forced in another layer.
jiparis
approved these changes
Oct 21, 2024
| @@ -35,7 +35,7 @@ type Workflow struct { | |||
| func (Workflow) Fields() []ent.Field { | |||
| return []ent.Field{ | |||
| field.String("name").Immutable(), | |||
| field.String("project").Optional(), | |||
| field.String("project"), | |||
There was a problem hiding this comment.
What are we doing with the current data? Will we migrate it?
There was a problem hiding this comment.
There is no need to migrate since all fields, in fact, have a project name, enforced somewhere else in the stack, not in the DB until now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allows users to create workflows with the same name in the same org as long as they are in different projects.
It also enforces now the requirement of passing
project nameduring attestation and updates documentation and dagger module.closes #1375