Skip to content

chore: upgrade golang to 1.21 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

jiparis
Copy link
Member

@jiparis jiparis commented Sep 20, 2023

Upgrade the version of golang now that the testing-container/golang version has been fixed.

Fixes #255

Signed-off-by: Jose I. Paris <[email protected]>
@jiparis
Copy link
Member Author

jiparis commented Sep 20, 2023

Hi, this is my first PR, let me know if everything looks good.
Thanks!

@migmartri migmartri self-requested a review September 21, 2023 09:03
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for your contribution! 🎉

@migmartri
Copy link
Member

@jiparis, the CI is complaining, could you run go mod tidy and try again?

Thanks!

Signed-off-by: Jose I. Paris <[email protected]>
@jiparis
Copy link
Member Author

jiparis commented Sep 21, 2023

@jiparis, the CI is complaining, could you run go mod tidy and try again?

Thanks!

Done. Sorry for the noise! It should be complete now.

Signed-off-by: Jose I. Paris <[email protected]>
@migmartri migmartri merged commit 5e9f9d6 into chainloop-dev:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testing containers not working on GitHub actions
2 participants