Add C++98 native test to ensure we don't break again #2136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obastemur
force-pushed
the
add_c99_test
branch
from
b763dd6 to
f08a1a6
Compare
|
LGTM |
|
Now that #2001 is merged, I tried closing and reopening this PR to clear the set of checks (hoping that it would clear the OSX tasks entirely). Unfortunately, it looks like in this case the failure of OSX tasks before the outage will prevent our automation from merging this PR (because it looks like tests failed, and we can't requeue). Options are to wait for OSX coverage to come back online or merge manually without OSX coverage. /cc @mmitche @obastemur |
|
@dilijev Thanks for dealing with this. IMHO we can wait for CI. Nothing urgent here. |
|
@dilijev Things should be up sometime today. |
|
@obastemur looks like there are still some failures related to |
|
@dilijev let me rebase. |
obastemur
force-pushed
the
add_c99_test
branch
from
f08a1a6 to
1a2dffc
Compare
|
@dilijev Thanks for the review |
chakrabot
pushed a commit
that referenced
this pull request
Dec 13, 2016
…ak again Merge pull request #2136 from obastemur:add_c99_test #2001 fixes Jsrt C99/C++98 compatibility issue. @dilijev brought the idea of adding a test to make sure we don't break it again. This native test should take care of that. p.s.: This PR will break until #2001 is merged. /cc @dilijev @jcoffland
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2001 fixes Jsrt C99/C++98 compatibility issue. @dilijev brought the idea of adding a test to make sure we don't break it again.
This native test should take care of that.
p.s.: This PR will break until #2001 is merged.
/cc @dilijev @jcoffland