WASM: Implement new Sign Extend operators #3741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed -WasmSignExtend2 to -WasmSignExtends
|
Fixed the cse case and added tests, ready to review |
MikeHolman
reviewed
Sep 19, 2017
lib/Backend/IRBuilderAsmJs.cpp
Outdated
| case Js::OpCodeAsmJs::I32Extend16_s: signExtendFromType = TyInt16; goto make_sign_extend; | ||
| make_sign_extend: | ||
| // Src2 is a dummy source, used only to carry the type to cast from | ||
| instr = IR::Instr::New(Js::OpCode::Conv_Prim, dstOpnd, srcOpnd, IR::IntConstOpnd::New(signExtendFromType, signExtendFromType, m_func), m_func); |
There was a problem hiding this comment.
this really needs a comment for why the int value is the type
MikeHolman
reviewed
Sep 19, 2017
lib/Backend/amd64/LowererMDArch.cpp
Outdated
| } | ||
|
|
||
| IR::RegOpnd * tempReg = IR::RegOpnd::New(fromType, this->m_func); | ||
| instr->InsertBefore(IR::Instr::New(Js::OpCode::MOV_TRUNC, tempReg, src1, m_func)); |
There was a problem hiding this comment.
Initially, I thought we needed to explicitly zero out the upper bits of the register, but MOVSX, takes care of setting the bits, so it is not actually needed.
MikeHolman
reviewed
Sep 19, 2017
lib/Backend/i386/LowererMDArch.cpp
Outdated
| Js::OpCode op = Js::OpCode::MOVSX; | ||
| if (src2->GetSize() == 2) | ||
| { | ||
| op = Js::OpCode::MOVSXW; |
There was a problem hiding this comment.
should assert else size == 1 (I guess you can't do that directly since it could be size == 4 and op isn't used, but something along those lines should be included)
MikeHolman
reviewed
Sep 19, 2017
| const tests = [ | ||
| makeCSETest("i32", "extend8_s" , null, [0xFF, 1, 0x1FF]), | ||
| makeCSETest("i32", "extend16_s", null, [0xFF, 1, 0xFFFF, 0x1FFFF]), | ||
| makeCSETest("i64", "extend8_s" , null, [0xFF, 1, 0x1FF]), |
There was a problem hiding this comment.
nice. very exhaustive :)
Cellule
force-pushed
the
wasm/signextend2
branch
from
32c49a6 to
3d0ad02
Compare
MikeHolman
approved these changes
Sep 19, 2017
chakrabot
pushed a commit
that referenced
this pull request
Sep 19, 2017
Merge pull request #3741 from Cellule:wasm/signextend2 Implement new operators as describe in https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#new-sign-extending-operators
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new operators as describe in
https://github.com/WebAssembly/threads/blob/master/proposals/threads/Overview.md#new-sign-extending-operators
This change is