Reenable and fix warning 4457 - declaration of '' hides function parameter #970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -387,8 +387,7 @@ void EtwTrace::LogLoopBodyLoadEvent(FunctionBody* body, LoopHeader* loopHeader, | |||
| { | |||
| methodInfo.method_id = iJIT_GetNewMethodID(); | |||
| size_t len = utf8::EncodeInto(utf8MethodName, methodName, (charcount_t)methodLength); | |||
| uint loopNumber = body->GetLoopNumber(loopHeader) + 1; | |||
There was a problem hiding this comment.
If this loopNumber is the same as the parameter and that data is contained in loopHeader, should we remove that parameter and extract that value from loopHeader? Otherwise, is there an assertion that should be made about whether the parameter loopNumber matches the value in body->GetLoopNumber(loopHeader)?
|
LGTM |
chakrabot
pushed a commit
that referenced
this pull request
May 18, 2016
…function parameter Merge pull request #970 from curtisman:warning4457
This was referenced Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.