FreeLoopBodyJobs race condition. #979
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To free data associated with a JIT loopbody, we create a FreeLoopBodyJob. If we can't allocate one of these (OOM), we create one on the stack, and wait for it to be processed. There was a race condition if we processed the job before starting to wait for it... The 'processed' flag avoids this.
|
|
1 similar comment
|
|
chakrabot
pushed a commit
that referenced
this pull request
May 14, 2016
Merge pull request #979 from LouisLaf:stackjob FreeLoopBodyJobs also need a processed flag to avoid race conditions. To free data associated with a JIT loopbody, we create a FreeLoopBodyJob. If we can't allocate one of these (OOM), we create one on the stack, and wait for it to be processed. There was a race condition if we processed the job before starting to wait for it... The 'processed' flag avoids this.
chakrabot
pushed a commit
that referenced
this pull request
May 16, 2016
Merge pull request #979 from LouisLaf:stackjob FreeLoopBodyJobs also need a processed flag to avoid race conditions. To free data associated with a JIT loopbody, we create a FreeLoopBodyJob. If we can't allocate one of these (OOM), we create one on the stack, and wait for it to be processed. There was a race condition if we processed the job before starting to wait for it... The 'processed' flag avoids this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeLoopBodyJobs also need a processed flag to avoid race conditions.
To free data associated with a JIT loopbody, we create a FreeLoopBodyJob. If we can't allocate one of these (OOM), we create one on the stack, and wait for it to be processed.
There was a race condition if we processed the job before starting to wait for it... The 'processed' flag avoids this.