Remove exception for missing clang 3.8 toolchain; update CI config. #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested this change in the linux-ci branch and no breaks resulted.
| @@ -122,6 +122,8 @@ def CreateLinuxBuildTasks = { machine, configTag, linuxBranch, nonDefaultTaskSet | |||
| // params: Project, BaseTaskName, IsPullRequest (appends '_prtest') | |||
| def jobName = Utilities.getFullJobName(project, config, isPR) | |||
|
|
|||
| def testableConfig = buildType in ['debug'] | |||
|
|
|||
| def infoScript = 'bash jenkins/get_system_info.sh' | |||
| def debugFlag = buildType == 'debug' ? '--debug' : '' | |||
There was a problem hiding this comment.
Do you think that the buildType, debugFlag and the testableConfig above could be arranged/defined a bit more efficiently?
There was a problem hiding this comment.
I followed the pattern used when there were more options. This works, but I'm open to suggestions.
Specifically, @digitalinfinity indicated that there are plans to add a test config like we have on Windows, where we will change line 125 to be:
def testableConfig = buildType in ['debug', 'test']
For debugFlag, I think the condition captures exactly what we want and allows us to compute the task string only once.
|
LGTM 👍 |
|
|
chakrabot
pushed a commit
that referenced
this pull request
May 13, 2016
… CI config. Merge pull request #982 from dilijev:linux-ci-m Tested these changes in the linux-ci branch and no breaks resulted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested these changes in the linux-ci branch and no breaks resulted.
This change is