Skip to content

Message: Fix message status update on deletion for sender and receiver - refs BT#21887 #5695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

'parent' => 'exact',
]
)]
#[ApiFilter(SearchFilter::class, properties: [

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

'receivers.receiverType' => 'exact',
'receivers.tags.tag' => 'exact',
'parent' => 'exact',
])]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line indented incorrectly; expected at least 4 spaces, found 0

@@ -85,7 +98,7 @@
public const MESSAGE_TYPE_INVITATION = 6;
public const MESSAGE_TYPE_CONVERSATION = 7;
// status
public const MESSAGE_STATUS_DELETED = 3;
public const MESSAGE_STATUS_SENDER_DELETED = 3;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line indented incorrectly; expected 8 spaces, found 4

@@ -46,6 +46,7 @@ class MessageRelUser
{
public const TYPE_TO = 1;
public const TYPE_CC = 2;
public const TYPE_SENDER = 8;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line indented incorrectly; expected 8 spaces, found 4

@@ -26,6 +29,8 @@ public function __construct(
private readonly FlysystemStorage $storage,
private readonly EntityManagerInterface $entityManager,
private readonly ResourceNodeRepository $resourceNodeRepository,
private readonly Security $security,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line indented incorrectly; expected 4 spaces, found 8

Copy link

Code Climate has analyzed commit e177042 and detected 11 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 6
Clarity 4
Complexity 1

View more on Code Climate.

@NicoDucou NicoDucou merged commit f31c756 into chamilo:master Jul 30, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants