Skip to content

Migration: Check schema differences post-migration - refs BT#20968 #5720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 27, 2024

Conversation

christianbeeznest
Copy link
Contributor

No description provided.

@@ -0,0 +1,614 @@
<?php
declare(strict_types=1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators

use Chamilo\CoreBundle\Migrations\AbstractMigrationChamilo;
use Doctrine\DBAL\Schema\Schema;

final class Version20240811221400 extends AbstractMigrationChamilo

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing class doc comment

final class Version20240811221400 extends AbstractMigrationChamilo
{

public function getDescription(): string

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

return 'Migration to update foreign key constraints, drop and create indexes, and alter table structures to ensure data consistency and prevent errors during execution.';
}

public function up(Schema $schema): void

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

$this->addSql('SET FOREIGN_KEY_CHECKS = 1;');
}

public function down(Schema $schema): void

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing function doc comment

@@ -0,0 +1,99 @@
<?php

declare(strict_types=1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a single space around assignment operators


use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

use Doctrine\ORM\Mapping as ORM;

#[ORM\Entity]
#[ORM\Table(name: 'justification_document')]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.


#[ORM\Entity]
#[ORM\Table(name: 'justification_document')]
class JustificationDocument

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must use "/**" style comments for a class comment

#[ORM\Table(name: 'justification_document')]
class JustificationDocument
{
#[ORM\Id]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.

Copy link

Code Climate has analyzed commit 0279752 and detected 377 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 355
Bug Risk 17
Complexity 3
Clarity 2

View more on Code Climate.

@NicoDucou NicoDucou merged commit 3f7ce91 into chamilo:master Aug 27, 2024
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants