OAuth2 #5753
OAuth2 #5753
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
|
||
| /* For licensing terms, see /license.txt */ | ||
|
|
||
| declare(strict_types=1); |
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Component\DependencyInjection\Attribute\AsDecorator; | ||
| use Symfony\Component\DependencyInjection\Attribute\AutowireDecorated; | ||
|
|
||
| #[AsDecorator(decorates: 'knpu.oauth2.provider_factory')] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| use Symfony\Component\DependencyInjection\Attribute\AutowireDecorated; | ||
|
|
||
| #[AsDecorator(decorates: 'knpu.oauth2.provider_factory')] | ||
| readonly class OAuth2ProviderFactoryDecorator |
There was a problem hiding this comment.
Missing class doc comment
| #[AsDecorator(decorates: 'knpu.oauth2.provider_factory')] | ||
| readonly class OAuth2ProviderFactoryDecorator | ||
| { | ||
| public function __construct( |
There was a problem hiding this comment.
Missing function doc comment
| readonly class OAuth2ProviderFactoryDecorator | ||
| { | ||
| public function __construct( | ||
| #[AutowireDecorated] |
There was a problem hiding this comment.
Perl-style comments are not allowed. Use "// Comment." or "/* comment */" instead.
| { | ||
| public function __construct( | ||
| #[AutowireDecorated] | ||
| private ProviderFactory $inner, |
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
| { | ||
| public function __construct( | ||
| #[AutowireDecorated] | ||
| private ProviderFactory $inner, |
There was a problem hiding this comment.
The first parameter of a multi-line function declaration must be on the line after the opening bracket
| public function __construct( | ||
| #[AutowireDecorated] | ||
| private ProviderFactory $inner, | ||
| private AuthenticationConfigHelper $authenticationConfigHelper, |
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
| #[AutowireDecorated] | ||
| private ProviderFactory $inner, | ||
| private AuthenticationConfigHelper $authenticationConfigHelper, | ||
| ) {} |
There was a problem hiding this comment.
Closing brace must be on a line by itself
| #[AutowireDecorated] | ||
| private ProviderFactory $inner, | ||
| private AuthenticationConfigHelper $authenticationConfigHelper, | ||
| ) {} |
There was a problem hiding this comment.
Closing brace must be on a line by itself
…gistration - refs BT#21881
…ogin/registration - refs BT#21881
| private AuthenticationConfigHelper $authenticationConfigHelper, | ||
| ) {} | ||
|
|
||
| public function createProvider( |
There was a problem hiding this comment.
Missing function doc comment
| array $redirectParams = [], | ||
| array $collaborators = [] | ||
| ): AbstractProvider { | ||
| $options = match ($class) { |
There was a problem hiding this comment.
Space before opening parenthesis of function call prohibited
| array $redirectParams = [], | ||
| array $collaborators = [] | ||
| ): AbstractProvider { | ||
| $options = match ($class) { |
There was a problem hiding this comment.
Space before opening parenthesis of function call prohibited
|
|
||
| /* For licensing terms, see /license.txt */ | ||
|
|
||
| declare(strict_types=1); |
There was a problem hiding this comment.
Add a single space around assignment operators
| use Symfony\Bundle\FrameworkBundle\Controller\AbstractController; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
| abstract class AbstractProviderController extends AbstractController |
There was a problem hiding this comment.
Missing class doc comment
|
Code Climate has analyzed commit 3aa77ce and detected 105 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
No description provided.