Assignment: Implement assignment tool with vue and symfony style - refs BT#22568 #6257
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| } | ||
|
|
||
| protected function filterProperty( | ||
| string $property, |
There was a problem hiding this comment.
Method filterProperty has 7 arguments (exceeds 4 allowed). Consider refactoring.
| return response.data | ||
| } | ||
|
|
||
| async function getAssignmentDetailForTeacher({ assignmentId, page = 1, itemsPerPage = 10, order = {} }) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return response.data | ||
| } | ||
|
|
||
| async function getAssignmentDetail({ assignmentId, page = 1, itemsPerPage = 10, order = {} }) { |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
| return $qb->getQuery()->getResult(); | ||
| } | ||
|
|
||
| public function findStudentProgressByCourse(Course $course, ?Session $session): array |
There was a problem hiding this comment.
Method findStudentProgressByCourse has 57 lines of code (exceeds 25 allowed). Consider refactoring.
| } | ||
|
|
||
| public function findAssignmentSubmissionsPaginated( | ||
| int $assignmentId, |
There was a problem hiding this comment.
Method findAssignmentSubmissionsPaginated has 5 arguments (exceeds 4 allowed). Consider refactoring.
…es - refs BT#22568
| class CreateStudentPublicationCommentAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( | ||
| Request $request, |
There was a problem hiding this comment.
Method __invoke has 8 arguments (exceeds 4 allowed). Consider refactoring.
| * Handles the creation logic for a student publication comment resource. | ||
| */ | ||
| public function handleCreateCommentRequest( | ||
| AbstractResource $resource, |
There was a problem hiding this comment.
Method handleCreateCommentRequest has 6 arguments (exceeds 4 allowed). Consider refactoring.
|
|
||
| class CreateStudentPublicationCommentAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( |
There was a problem hiding this comment.
Method __invoke has 47 lines of code (exceeds 25 allowed). Consider refactoring.
| class CreateStudentPublicationFileAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( | ||
| Request $request, |
There was a problem hiding this comment.
Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
|
|
||
| class CreateStudentPublicationFileAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( |
There was a problem hiding this comment.
Method __invoke has 29 lines of code (exceeds 25 allowed). Consider refactoring.
| return $description; | ||
| } | ||
|
|
||
| protected function filterProperty( |
There was a problem hiding this comment.
Function filterProperty has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| class CreateStudentPublicationCorrectionFileAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( | ||
| Request $request, |
There was a problem hiding this comment.
Method __invoke has 6 arguments (exceeds 4 allowed). Consider refactoring.
|
|
||
| class CreateStudentPublicationCorrectionFileAction extends BaseResourceFileAction | ||
| { | ||
| public function __invoke( |
There was a problem hiding this comment.
Method __invoke has 27 lines of code (exceeds 25 allowed). Consider refactoring.
| return $qb->getQuery()->getResult(); | ||
| } | ||
|
|
||
| public function findStudentProgressByCourse(Course $course, ?Session $session): array |
There was a problem hiding this comment.
Function findStudentProgressByCourse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
| export default makeService("c_student_publications") | ||
| async function findStudentAssignments() { | ||
| const { sid, cid, gid } = useCidReq() | ||
| const params = new URLSearchParams({ cid, ...(sid && { sid }), ...(gid && { gid }) }).toString() |
There was a problem hiding this comment.
Similar blocks of code found in 2 locations. Consider refactoring.
|
|
||
| async function getUnsubmittedUsers(assignmentId) { | ||
| const { sid, cid, gid } = useCidReq() | ||
| const params = new URLSearchParams({ cid, ...(sid && { sid }), ...(gid && { gid }) }).toString() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| export default makeService("c_student_publications") | ||
| async function findStudentAssignments() { | ||
| const { sid, cid, gid } = useCidReq() | ||
| const params = new URLSearchParams({ cid, ...(sid && { sid }), ...(gid && { gid }) }).toString() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
|
|
||
| async function getAssignmentMetadata(assignmentId) { | ||
| const { sid, cid, gid } = useCidReq() | ||
| const params = new URLSearchParams({ cid, ...(sid && { sid }), ...(gid && { gid }) }).toString() |
There was a problem hiding this comment.
Similar blocks of code found in 3 locations. Consider refactoring.
| @@ -142,4 +148,197 @@ private function addFileTypeQueryBuilder(?string $fileType, ?QueryBuilder $qb = | |||
| ->setParameter('filetype', $fileType) | |||
| ; | |||
| } | |||
|
|
|||
| public function findVisibleAssignmentsForStudent(Course $course, ?Session $session = null): array | |||
There was a problem hiding this comment.
Method findVisibleAssignmentsForStudent has 32 lines of code (exceeds 25 allowed). Consider refactoring.
…improvements - refs BT#22568
…rovements - refs BT#22568
| $nodeId = $publication->getResourceNode()->getId(); | ||
| $assignmentId = $publication->getIid(); | ||
|
|
||
| return api_get_path(WEB_PATH) . |
There was a problem hiding this comment.
Avoid too many return statements within this method.
|
Code Climate has analyzed commit 2296dd0 and detected 22 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
Variables de idioma : Assignment name |
No description provided.