Skip to content

Conversation

sungik-choi
Copy link
Contributor

Self Checklist

  • I wrote a PR title in English and added an appropriate label to the PR.
  • I wrote the commit message in English and to follow the Conventional Commits specification.
  • I added the changeset about the changes that needed to be released. (or didn't have to)
  • I wrote or updated documentation related to the changes. (or didn't have to)
  • I wrote or updated tests related to the changes. (or didn't have to)
  • I tested the changes in various browsers. (or didn't have to)
    • Windows: Chrome, Edge, (Optional) Firefox
    • macOS: Chrome, Edge, Safari, (Optional) Firefox

Related Issue

Summary

Details

Breaking change? (Yes/No)

References

Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: e7def5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Feb 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7305476) 84.24% compared to head (e7def5a) 84.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha    #1998   +/-   ##
=======================================
  Coverage   84.24%   84.24%           
=======================================
  Files         142      142           
  Lines        2279     2279           
  Branches      607      607           
=======================================
  Hits         1920     1920           
  Misses        282      282           
  Partials       77       77           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sungik-choi sungik-choi changed the title [WIP] Storybook Vite & Fix storybook build error [WIP] Storybook Vite & Fix storybook build error(ing) Feb 16, 2024
@sungik-choi sungik-choi changed the title [WIP] Storybook Vite & Fix storybook build error(ing) [WIP] Storybook Vite & Fix storybook build error Feb 16, 2024
@yangwooseong yangwooseong mentioned this pull request Feb 19, 2024
6 tasks
@sungik-choi sungik-choi self-assigned this Feb 19, 2024
@sungik-choi
Copy link
Contributor Author

스토리북 버전을 7.5.3 으로 고정해서 빌드 에러를 수정했고, Vite가 v5부터 장기적으로 ESM만 지원할 예정인데 bezier-react 설정과는 맞지 않는 부분이 있어서 굳이 vite로 업그레이드할 필요성은 없어보입니다.

@sungik-choi sungik-choi deleted the build/storybook-vite branch February 27, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant