-
Notifications
You must be signed in to change notification settings - Fork 12k
Adds different point styles #1905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mathiask88 I like the idea! Would make a great addition to v2. |
Added tests and rebased. |
Looks good. Thanks @mathiask88 |
Looks like it might not stroke properly. |
Hi. How I can add my own point styles? |
@mathiask88 I didn't notice any colour issues. Do you have a jsfiddle? |
@mathiask88 I see that I should replace method Chart.elements.Point.styles.myOwnStyleName = function() {...} will be better? And |
@Raf2k Something like this? https://github.com/mathiask88/Chart.js/commit/8636ae2fc888ef0f5e8cc500595d5af680b8b6ed Edit: updated link |
@etimberg What do you think of the mentioned addition? Something the majority would appreciate? |
@mathiask88 I think it would make a good addition :) |
@etimberg I added some point styles like in Excel:

I know tests are failing, but I wanted to know what do you think of this, before changing the tests.