Skip to content

Conversation

KoyoSE
Copy link
Contributor

@KoyoSE KoyoSE commented Nov 27, 2016

Fixed tooltip labelling on Bar chart when min option was set.
In addition, Fixed the tooltip label problem when 'xLabel' , 'yLabel' was set.

Resolves #3618

Before

issue3618-before
All tooltip labels should be May.
https://jsfiddle.net/KoyoSE/bvo2bc5f/1/

After

issue3618-after

https://jsfiddle.net/KoyoSE/6f3hbLr1/2/

When added plugin

issue3618-plugin

https://jsfiddle.net/KoyoSE/6f3hbLr1/3/

Copy link
Member

@etimberg etimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for including the fiddles showing the changes

@KoyoSE
Copy link
Contributor Author

KoyoSE commented Nov 28, 2016

@etimberg My pleasure! By the way, I am still a Github beginner. What should I do after this? Should I close this?

@etimberg
Copy link
Member

@KoyoSE once a few others look at this we'll merge it. You won't have to do anything :)

@KoyoSE
Copy link
Contributor Author

KoyoSE commented Nov 28, 2016

@etimberg I see. OK thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants