Skip to content

New time scale ticks.mode and ticks.source options #4507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2017
Merged

New time scale ticks.mode and ticks.source options #4507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c1a823
New time scale `ticks.mode/.source` options
simonbrunel Jul 15, 2017
acd4146
Enhance interpolation when one or zero tick
simonbrunel Jul 19, 2017
8bd2422
Code review
simonbrunel Jul 19, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/helpers/helpers.time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
var moment = require('moment');
moment = typeof(moment) === 'function' ? moment : window.moment;

var helpers = require('./helpers.core');

var interval = {
millisecond: {
size: 1,
Expand Down Expand Up @@ -53,7 +55,7 @@ function generateTicksNiceRange(options, dataRange, niceRange) {
var ticks = [];
if (options.maxTicks) {
var stepSize = options.stepSize;
var startTick = options.min !== undefined ? options.min : niceRange.min;
var startTick = helpers.isNullOrUndef(options.min)? niceRange.min : options.min;
var majorUnit = options.majorUnit;
var majorUnitStart = majorUnit ? moment(startTick).add(1, majorUnit).startOf(majorUnit) : startTick;
var startRange = majorUnitStart.valueOf() - startTick;
Expand Down
Loading