Skip to content

Call update() and render() with a config object #5592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2018
Merged

Call update() and render() with a config object #5592

merged 1 commit into from
Jun 24, 2018

Conversation

nagix
Copy link
Contributor

@nagix nagix commented Jun 24, 2018

This replaces old-style arguments of update() and render() calls with a config object.

@simonbrunel simonbrunel added this to the Version 2.8 milestone Jun 24, 2018
@simonbrunel simonbrunel requested a review from etimberg June 24, 2018 09:51
@etimberg etimberg merged commit 7cf1323 into chartjs:master Jun 24, 2018
@nagix nagix deleted the issue-5592 branch June 24, 2018 18:42
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Mar 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@nagix @etimberg
Call update() and render() with a config object (chartjs#5592)
cbe465f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbrunel simonbrunel simonbrunel approved these changes

@etimberg etimberg etimberg approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
Version 2.7.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nagix @simonbrunel @etimberg