Skip to content

Optimize the npm package size #6105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 3, 2019
Merged

Optimize the npm package size #6105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22bdcf1
Optimize the npm package size
simonbrunel Mar 2, 2019
b135188
Rename `chart.js` to `index.js`
simonbrunel Mar 2, 2019
946098f
Remove sources from npm package and create alias
simonbrunel Mar 2, 2019
f36d410
Remove the alias
simonbrunel Mar 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .npmignore
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@ module.exports = function(karma) {
{pattern: 'test/fixtures/**/*.png', included: false},
'node_modules/moment/min/moment.min.js',
'test/index.js',
'src/chart.js'
'src/index.js'
].concat(args.inputs),

preprocessors: {
'test/index.js': ['rollup'],
'src/chart.js': ['sources']
'src/index.js': ['sources']
},

rollupPreprocessor: {
Expand Down
6 changes: 6 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,12 @@
"bugs": {
"url": "https://github.com/chartjs/Chart.js/issues"
},
"files": [
"bower.json",
"composer.json",
"dist/*.css",
"dist/*.js"
],
"devDependencies": {
"clean-css": "^4.2.1",
"coveralls": "^3.0.0",
Expand Down
2 changes: 1 addition & 1 deletion rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const optional = require('./rollup.plugins').optional;
const stylesheet = require('./rollup.plugins').stylesheet;
const pkg = require('./package.json');

const input = 'src/chart.js';
const input = 'src/index.js';
const banner = `/*!
* Chart.js v${pkg.version}
* ${pkg.homepage}
Expand Down
0 src/chart.js → src/index.js
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion src/scales/scale.category.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,5 +130,5 @@ module.exports = Scale.extend({
}
});

// INTERNAL: static default options, registered in src/chart.js
// INTERNAL: static default options, registered in src/index.js
module.exports._defaults = defaultConfig;
2 changes: 1 addition & 1 deletion src/scales/scale.linear.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,5 +186,5 @@ module.exports = LinearScaleBase.extend({
}
});

// INTERNAL: static default options, registered in src/chart.js
// INTERNAL: static default options, registered in src/index.js
module.exports._defaults = defaultConfig;
2 changes: 1 addition & 1 deletion src/scales/scale.logarithmic.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,5 +345,5 @@ module.exports = Scale.extend({
}
});

// INTERNAL: static default options, registered in src/chart.js
// INTERNAL: static default options, registered in src/index.js
module.exports._defaults = defaultConfig;
2 changes: 1 addition & 1 deletion src/scales/scale.radialLinear.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,5 +530,5 @@ module.exports = LinearScaleBase.extend({
}
});

// INTERNAL: static default options, registered in src/chart.js
// INTERNAL: static default options, registered in src/index.js
module.exports._defaults = defaultConfig;
2 changes: 1 addition & 1 deletion src/scales/scale.time.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,5 +764,5 @@ module.exports = Scale.extend({
}
});

// INTERNAL: static default options, registered in src/chart.js
// INTERNAL: static default options, registered in src/index.js
module.exports._defaults = defaultConfig;