Skip to content

Demonstrate multiple units on financial timeseries sample #6119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 28, 2019
Merged

Demonstrate multiple units on financial timeseries sample #6119

merged 1 commit into from
Mar 28, 2019

Conversation

benmccann
Copy link
Contributor

No description provided.

@benmccann benmccann requested review from etimberg, nagix and kurkle March 25, 2019 14:22
@simonbrunel simonbrunel added this to the Version 2.9 milestone Mar 28, 2019
@simonbrunel simonbrunel merged commit 30cb91d into chartjs:master Mar 28, 2019
@nagix
Copy link
Contributor

nagix commented Mar 28, 2019

Bar charts don't work after this change: https://www.chartjs.org/samples/master/scales/time/financial.html

@benmccann
Copy link
Contributor Author

Thanks for catching. I've sent a fix here: #6169

@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @simonbrunel
Demonstrate multiple units on financial timeseries sample (chartjs#6119)
98a8399
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Closed
1 task
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jul 5, 2021
Open
1 task
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

+1 more reviewer

@nagix nagix nagix approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: documentation
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
5 participants
@benmccann @nagix @etimberg @kurkle @simonbrunel