Skip to content

Lazily compute label sizes #6351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2019
Merged

Lazily compute label sizes #6351

merged 2 commits into from
Jun 27, 2019

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Jun 22, 2019 •
edited
Loading

Lazily computing has the following benefits:

  • longestLabelWidth was previously set in a somewhat arbitrary place. This now sets it at the same time as _labelSizes
  • This makes it easier to reorder methods in further refactorings because we don't need to worry about whether _labelSizes has been set
  • Removes two levels of indentation in calculateTickRotation
  • Fixes CodeClimate warning: Function calculateTickRotation has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring

kurkle
kurkle reviewed Jun 23, 2019
View reviewed changes
nagix
nagix reviewed Jun 24, 2019
View reviewed changes
@benmccann benmccann requested review from nagix, kurkle and etimberg June 26, 2019 15:38
@etimberg etimberg merged commit fb3d6ab into chartjs:master Jun 27, 2019
@nagix nagix added this to the Version 2.9 milestone Jun 27, 2019
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@benmccann @etimberg
Lazily compute label sizes (chartjs#6351)
aead7f2 
* Lazily compute label sizes

* Reduce file size
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
@renovate renovate bot mentioned this pull request Jun 6, 2021
Open
1 task
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg etimberg approved these changes

@kurkle kurkle kurkle approved these changes

+1 more reviewer

@nagix nagix nagix approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: chore
Projects
None yet
Milestone
Version 2.9
Development

Successfully merging this pull request may close these issues.
4 participants
@benmccann @nagix @etimberg @kurkle