Skip to content

Make sure zeroLineIndex is defined #6528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2019
Merged

Make sure zeroLineIndex is defined #6528

merged 1 commit into from
Sep 19, 2019

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Sep 18, 2019 •
edited
Loading

Pen

Closes: #5032

@benmccann
Copy link
Contributor

It looks like zeroLineIndex is not present in the documentation. Perhaps you could add it as part of this PR?

@kurkle
Copy link
Member Author

kurkle commented Sep 18, 2019

Its not documented, but I'd consider it internal. There are number of configuration options documented in grid-line-configuration that are based on the index being defined.

benmccann
benmccann approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yeah. It's not an option anyway. Just a class member. Lgtm

@etimberg etimberg merged commit b24e42b into chartjs:master Sep 19, 2019
@kurkle kurkle mentioned this pull request Oct 25, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Nov 9, 2019
Merged
@kurkle kurkle deleted the zeroLineIndex branch November 13, 2019 06:12
This was referenced Mar 4, 2020
Open
Open
@vpetersson vpetersson mentioned this pull request Mar 7, 2020
Merged
This was referenced Mar 9, 2020
Closed
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 1, 2020
Open
This was referenced Apr 14, 2020
Open
Open
exwm pushed a commit to exwm/Chart.js that referenced this pull request Apr 30, 2021
@kurkle @etimberg
Make sure zeroLineIndex is defined (chartjs#6528)
859968a
This was referenced Jun 1, 2021
Closed
Merged
Closed
Open
Closed
Open
Open
This was referenced Jul 5, 2021
Closed
Open
This was referenced Jul 27, 2021
Closed
Merged
Merged
This was referenced Oct 14, 2021
Merged
Closed
@jw jw mentioned this pull request Jan 17, 2022
Open
1 task
This was referenced Jan 21, 2022
Merged
Closed
This was referenced Feb 4, 2022
Closed
Closed
This was referenced Mar 7, 2022
Open
Open
Open
@mend-for-github-com mend-for-github-com bot mentioned this pull request Aug 13, 2022
Merged
1 task
This was referenced Nov 29, 2022
Closed
Closed
@mend-for-github-com mend-for-github-com bot mentioned this pull request Jan 26, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@etimberg etimberg etimberg approved these changes

+1 more reviewer

@benmccann benmccann benmccann approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] zeroLineIndex is undefined for yAxis, prevents setting of zeroLine attributes

3 participants

@kurkle @benmccann @etimberg