Skip to content

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Nov 8, 2019

Closes #6644

@etimberg
Copy link
Member

etimberg commented Nov 9, 2019

Do we have any idea how many people want this the other way? Perhaps a better way to handle this is an option in the legend. That way 2.9.3 will work by default same as 2.9.2 but can be switched. For v3 we can investigate changing the default

@benmccann
Copy link
Contributor Author

benmccann commented Nov 9, 2019

This way actually gives you an option for the legend. If you set backgroundColor: 'rgba(0,0,0,0)' instead of fill: false then the middle will be empty. With the current code I'm not sure there's a way to manually set the legend

I haven't seen anyone request it the other way. The closest data point I have is in #6644 (comment) where they said they did an office poll and it came out 22 to 2 in favor of this way. It seems like people really don't like the current way because we got almost as many complaints about it as IE being broken.

I'm not too worried about changing the behavior because I view it as fixing a deviation from backwards compatibility. We changed it from 2.8 to 2.9, so this it just fixing it to maintain backwards compatibility.

@ankane
Copy link
Contributor

ankane commented Nov 9, 2019

fwiw, I thought this was a bug with the 2.9.x release until I saw the discussion on #6644. Have been considering rolling Chartkick back to 2.8.0 until there's a way to restore the previous behavior.

@etimberg
Copy link
Member

@benmccann good point on the transparent fill option. Other work around to get the old behaviour is to change the default legend callback to return different styles.

@benmccann benmccann requested a review from kurkle November 10, 2019 22:49
@etimberg etimberg merged commit 49c4761 into chartjs:master Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"fill: false" option on dataset causes legend to also not fill

4 participants