Skip to content

Conversation

Yeon22
Copy link

@Yeon22 Yeon22 commented May 3, 2020

No description provided.

@benmccann
Copy link
Contributor

Thank you for this. We are currently working on Chart.js 3 which will migrate the docs to Docusaurus #7295. We are using an alpha version of Docusaurus 2, which does not yet have translation support (facebook/docusaurus#2651). However, once this is added that might be the best way to support translations.

I think that adding the link in this PR might not be a good idea at the moment because master is for Chart.js 3 and your docs are for Chart.js 2. I worry that you and the community will have a really hard time keeping the docs up-to-date if you're translating https://github.com/chartjs/chartjs.github.io directly because that's the output of our documentation build system. But it would be interesting to start accepting contributions to the documentation source so that everytime we release a new version of the docs the translated versions get rebuilt as well

@Yeon22
Copy link
Author

Yeon22 commented May 5, 2020

Thank you. I’ll check build system our repo and change it.

@benmccann
Copy link
Contributor

@Yeon22 thank for putting in all the work to do this! I'll go ahead and close this for now to keep the review queue empty and we can figure out how to revisit this once Docusaurus adds i18n support, which should happen before the final release

@benmccann benmccann closed this Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants