Skip to content

Fix Maximum call stack size exception in _computeLabelSizes #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Fix Maximum call stack size exception in _computeLabelSizes #7906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/core/core.scale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -894,6 +894,8 @@ export default class Scale extends Element {
const widths = [];
const heights = [];
const offsets = [];
let widestLabelSize = 0;
let highestLabelSize = 0;
let ticks = me.ticks;
if (sampleSize < ticks.length) {
ticks = sample(ticks, sampleSize);
Expand Down Expand Up @@ -926,11 +928,13 @@ export default class Scale extends Element {
widths.push(width);
heights.push(height);
offsets.push(lineHeight / 2);
widestLabelSize = Math.max(width, widestLabelSize);
highestLabelSize = Math.max(height, highestLabelSize);
}
garbageCollect(caches, length);

const widest = widths.indexOf(Math.max.apply(null, widths));
const highest = heights.indexOf(Math.max.apply(null, heights));
const widest = widths.indexOf(widestLabelSize);
const highest = heights.indexOf(highestLabelSize);

function valueAt(idx) {
return {
Expand Down