Avoid mutating annotation object for Lightning Web Security (LWS) #980
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm looking to ensure the plugin is compatible with the LWS restrictions so it can be implemented in LWC. While I'm sure an uncommon usage here it would be nice if it can be compatible.
#979
The main issue is setting of
value.id = key
inbeforeUpdate
I have simply removed the assignment to the object to avoid mutation, I'm unclear on any downstream impacts of removing this assignment. It looks that the
id
is used inelement.js
getContext
. However, annotations seem to function without the assignment.I tried cloning the object however
afterUpdate
->updateElements
fails onannotationOptions.setContext(getContext(chart, element, elements, annotationOptions));
where setContext is now undefined. So cloning would require a deeper fixReading for LWS restrictions.
https://developer.salesforce.com/docs/platform/lightning-components-security/guide/lws-mutation-alternatives.html
https://developer.salesforce.com/docs/platform/lightning-components-security/guide/lws-proxies.html
https://developer.salesforce.com/docs/platform/lightning-components-security/guide/lws-proxies.html