-
-
Notifications
You must be signed in to change notification settings - Fork 21
Make async-std dependency optional #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the current version does not use the async-std runtime, it only uses some primitives of it, so it should be runtime agnostic already. I haven’t tested it though |
The problem is that it (non-optionally) depends on async-std and brings in a lot of unneeded code (and compile-time) if using it with a different async runtime. Ideally instead of async-std, it would only use whatever is available from the futures crate. Is there anything used here that is only available in async-std? |
yes: https://github.com/async-email/async-native-tls/blob/master/src/acceptor.rs#L60-L61 |
I see. That makes it rather tricky to make the whole things runtime-independent as you actually depend on async-std :) |
Yeah, I guess it could be behind a default feature flag, and the exposed API that is runtime independent could be smaller |
Maybe that solves it? #14 |
I'm not sure if this is possible, but it would be great if the async-std dependency could be made optional so that (like async-tls) this could also be used by other runtimes (e.g. the one from glib).
The text was updated successfully, but these errors were encountered: