Skip to content

feat: replace async-std dependency with futures #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from Mar 29, 2020
Merged

feat: replace async-std dependency with futures #18

merged 3 commits into from Mar 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 28, 2020

The async-std runtime shares traits with the futures crate, and async-native-tls doesn't really use anything else besides those traits. Therefore, we can just switch the async-std dependency with futures.

This PR inherits #14.
Closes #10.

llebout and others added 3 commits January 14, 2020 20:22
This allows to drop the async-std runtime dependency
and operate only on `futures-util` traits.
@dignifiedquire
Copy link
Contributor

I wonder if we should just call it futures runtime instead

@ghost
Copy link
Author

ghost commented Mar 28, 2020

Maybe, but "futures" is not really a runtime...

@dignifiedquire dignifiedquire changed the title Replace async-std dependency with futures feat: replace async-std dependency with futures Mar 29, 2020
@dignifiedquire dignifiedquire merged commit f18840b into chatmail:master Mar 29, 2020
@dignifiedquire
Copy link
Contributor

Maybe, but "futures" is not really a runtime...

fair enough

@ghost ghost deleted the drop-async-std branch March 29, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make async-std dependency optional
2 participants