Do not start an IMAP loop for sent folder if watching sentbox is enabled but no sentbox is configured

[link2xt]

Currently in the Python test test_mvbox_sentbox_threads the option is enabled, but because CI server nine.testrun.org does not have a Sent folder, IMAP loop is started, opens a connection and goes to fake idle. We should not open a connection at all in this case.

This is why the test is marked as xfail in
#5104

[link2xt]

The test is still marked as xfail. We should probably create Sent folder manually in Python before testing.

[iequidoo]

Maybe i don't look into the right place, but i don't see that test_mvbox_sentbox_threads() is marked as xfail. Btw, with this change:

--- a/python/tests/test_1_online.py                                                                                                                                                                                  
+++ b/python/tests/test_1_online.py                                                                                                                                                                                  
@@ -399,7 +399,7 @@ def test_enable_mvbox_move(acfactory, lp):                                                                                                                                                       
                                                                                                                                                                                                                     
 def test_mvbox_sentbox_threads(acfactory, lp):                                                                                                                                                                      
     lp.sec("ac1: start with mvbox thread")                                                                                                                                                                          
-    ac1 = acfactory.new_online_configuring_account(mvbox_move=True, sentbox_watch=True)                                                                                                                             
+    ac1 = acfactory.new_online_configuring_account(mvbox_move=True, sentbox_watch=False)                                                                                                                            
                                                                                                                                                                                                                     
     lp.sec("ac2: start without mvbox/sentbox threads")                                                                                                                                                              
     ac2 = acfactory.new_online_configuring_account(mvbox_move=False, sentbox_watch=False)                                                                                                                           
@@ -407,6 +407,10 @@ def test_mvbox_sentbox_threads(acfactory, lp):                                                                                                                                                  
     lp.sec("ac2 and ac1: waiting for configuration")                                                                                                                                                                
     acfactory.bring_accounts_online()                                                                                                                                                                               
                                                                                                                                                                                                                     
+    lp.sec("ac1: create and configure sentbox")                                                                                                                                                                     
+    ac1.direct_imap.create_folder("Sent")                                                                                                                                                                           
+    ac1.set_config("sentbox_watch", "1")

i see the correct log, at least the Sent folder is fetched:

19.54 [events-ac1] INFO src/imap.rs:523: No new emails in folder "Sent".

But i don't understand the test itself, how is it expected to fail if the sentbox thread isn't started? I don't see anything that depends on that

[iequidoo]

The test was improved in #5364, now it checks at least that mvbox and sentbox get configured after setting mvbox_move and sentbox_watch.