Skip to content

Fix Rust 1.57 compiler and clippy warnings #2863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2021
Merged

Fix Rust 1.57 compiler and clippy warnings #2863

merged 4 commits into from
Dec 4, 2021

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Dec 4, 2021

No description provided.

r10s
r10s approved these changes Dec 4, 2021
View reviewed changes
Copy link
Contributor

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for taking care.

we could also remove os_name from ffi, however, as it will introduce some noise, maybe better do that after desktop is released (in case we need another core ;)

@link2xt link2xt merged commit a74377b into master Dec 4, 2021
@link2xt link2xt deleted the clippy-1.57 branch December 4, 2021 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@link2xt @r10s