Skip to content

enable BccSelf by default #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 24, 2022
Merged

enable BccSelf by default #3612

merged 3 commits into from
Sep 24, 2022

Conversation

r10s
Copy link
Contributor

@r10s r10s commented Sep 24, 2022

enabling BccSelf improves user experience as
it is easier to set up another device
and ppl will also see "all" messages in other user agents directly.

for uncounted user problems, after diving into the issue,
the resulting device was "turn on BccSelf".
disabled BccSelf was probably the the number one single reason
of user problems.
(just recently again, this is the reason for this change, that, however, was discussed offline many times, but it never ends in a pr :)

main drawback of the change are potentially double notifications
when using a shared account and having another mail app on the same device (see #825).
however, we meanwhile do not recommend shared accounts at all,
the issue is also fixable by the other mail apps (as done by K-9)
and could be even regarded as a feature (you can decide which app to use for ansering).
but at the end the drawback is probably much smaller than the issues reported above.

@adbenitez if we want that change also for nauta, we also have to adapt nauta's provider-db entry.

enabling `BccSelf` improves user experience as
it is easier to set up another device
and ppl will also see "all" messages in other user agents directly.

for uncounted user problems, after diving into the issue,
the resulting device was "turn on BccSelf".
disabled `BccSelf` was probably the the number one single reason
of user problems.

main drawback of the change are potentially double notifications
when using a shared account and having another mail app on the same device.
however, we meanwhile do not recommend shared accounts at all,
the issue is also fixable by the other mail apps (as done by K-9)
and could be even regarded as a feature (you can decide which app to use for ansering).
but at the end the drawback is probably much smaller than the issues reported above.
@r10s r10s requested review from hpk42, link2xt and adbenitez September 24, 2022 16:47
Copy link
Collaborator

@adbenitez adbenitez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree that it is better enabling it by default, annoyances with contacts having issues with multidevice setup has become a more visible issue lately.

I think even for nauta it would be ok, because due to "delete messages from server at once" no copy to self is sent anyway IIRC, was it even disabled for nauta??? that is not necessary

@r10s
Copy link
Contributor Author

r10s commented Sep 24, 2022

I think even for nauta it would be ok, because due to "delete messages from server at once" no copy to self is sent anyway IIRC, was it even disabled for nauta??? that is not necessary

i double checked, indeed the bcc_self instruction is void if delete_server_after is set to 1 (converted to Some(0) here). so, for nauta, the default does not change.

@r10s
Copy link
Contributor Author

r10s commented Sep 24, 2022

i think, the clippy errors from https://github.com/deltachat/deltachat-core-rust/pull/3612/checks?check_run_id=8531158005 are unrelated? wondering, why ci on master is green then, cc @link2xt @flub

@link2xt
Copy link
Collaborator

link2xt commented Sep 24, 2022

i think, the clippy errors from https://github.com/deltachat/deltachat-core-rust/pull/3612/checks?check_run_id=8531158005 are unrelated? wondering, why ci on master is green then, cc @link2xt @flub

clippy runs on stable and Rust 1.64 with new clippy was just released. Maybe we should just pin clippy to 1.63 and update it from time to time together with fixing clippy bugs.

Copy link
Collaborator

@link2xt link2xt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. What happens if user never changed this setting before? Looks like it will become enabled automatically, probably ok. But if user opened the settings window before, then UI probably saved "0" explicity and it will not be updated. We don't have explicit "default, user never touched this setting" value like e.g. about:config in firefox/thunderbird has, so there may be some difference in behaviour for different UIs.

  2. There is still a maybe_add_bcc_self_device_msg which just became less useful, but seems worth keeping in case user disabled BCC to self explicitly.

@r10s
Copy link
Contributor Author

r10s commented Sep 24, 2022

ah, yes, forgot about that there is a maybe_add_bcc_self_device_msg :) but i agree, it is good to keep that, esp. as we reliably change the default only for new installations.

@r10s r10s merged commit cd6d181 into master Sep 24, 2022
@r10s r10s deleted the bcc-self-default-on branch September 24, 2022 19:54
r10s added a commit to deltachat/deltachat-pages that referenced this pull request May 7, 2024
the default is "On" since some time,
see chatmail/core#3612

moreover, when on that line anyways, pick up the literally correct name.
r10s added a commit to deltachat/deltachat-pages that referenced this pull request May 8, 2024
the default is "On" since some time,
see chatmail/core#3612

moreover, when on that line anyways, pick up the literally correct name.
link2xt added a commit that referenced this pull request Aug 30, 2024
bcc_self has been enabled by default
since core version 1.95.0
by merging
PR <#3612>.

However deltachat.h documentation
still incorrectly said that bcc_self is disabled by default.
link2xt added a commit that referenced this pull request Aug 30, 2024
bcc_self has been enabled by default
since core version 1.95.0
by merging
PR <#3612>.

However deltachat.h documentation
still incorrectly said that bcc_self is disabled by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants