-
-
Notifications
You must be signed in to change notification settings - Fork 99
Show non-deltachat emails by default for new installations #4019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3609bbd
to
b13a983
Compare
Since it caused the massive discussion with many people involved, i expect at least 3 approvals here :) |
@iequidoo If only I could code, I would review this PR, of course! ;) However, thanks for your invitation! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm technically, thanks a lot! i also reviewed the changed tests wrt changed default - i first thought we do not have a test for classic-mail not showing up when show_emails==0
, however, there is test_adhoc_group_show_chats_only()
, so that seems good enough.
and i agree, let's wait a bit longer wrt merging and get more approvals. there were some ideas around wrt a (device) message once the first classic email is received or so. just saying as it was discussed before, i am not sure this is needed, it may be even more confusing. as also discussed, in a mixed setup the more annoying part seems the other way round, dc messages shown in classic mua.
all in all, i think the new default is less confusing and we can give it a try - the old one was mainly because of some classic email types not being supported, which has changed since then.
I decided not to add a device message because maybe it's better just to point to that in "What's new in X?" message and what a user should do to switch to the new defaults. A separate message may be excessive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
b13a983
to
f8e93dc
Compare
This caused too many problems after switching the default setting for `show_emails` from DC_SHOW_EMAILS_OFF to DC_SHOW_EMAILS_ALL in <#4019> There is a topic <https://support.delta.chat/t/setting-no-chats-only-for-show-classic-e-mails-showing-classic-emails/2481> on the forum with multiple requests to revert this setting due to old emails being downloaded.
This caused too many problems after switching the default setting for `show_emails` from DC_SHOW_EMAILS_OFF to DC_SHOW_EMAILS_ALL in <#4019> There is a topic <https://support.delta.chat/t/setting-no-chats-only-for-show-classic-e-mails-showing-classic-emails/2481> on the forum with multiple requests to revert this setting due to old emails being downloaded.
This caused too many problems after switching the default setting for `show_emails` from DC_SHOW_EMAILS_OFF to DC_SHOW_EMAILS_ALL in <#4019> There is a topic <https://support.delta.chat/t/setting-no-chats-only-for-show-classic-e-mails-showing-classic-emails/2481> on the forum with multiple requests to revert this setting due to old emails being downloaded.
No description provided.