Skip to content

feat: Pause IO for BackupProvider #4182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2023
Merged

feat: Pause IO for BackupProvider #4182

merged 2 commits into from
Mar 20, 2023

Conversation

flub
Copy link
Contributor

@flub flub commented Mar 20, 2023 •
edited
Loading

This makes the BackupProvider automatically invoke pause-io while it
is needed.

It needed to make the guard independent from the Context lifetime to
make this work. Which is a bit sad.

Closes #4176

#skip-changelog

@flub
feat: Pause IO for BackupProvider
06dd227 
This makes the BackupProvider automatically invoke pause-io while it
is needed.

It needed to make the guard independent from the Context lifetime to
make this work.  Which is a bit sad.
@flub flub requested review from link2xt and r10s March 20, 2023 11:07
@flub flub mentioned this pull request Mar 20, 2023
Closed
25 tasks
@flub
Copy link
Contributor Author

flub commented Mar 20, 2023

I think this failures are unrelated?

@r10s
Copy link
Contributor

r10s commented Mar 20, 2023

ftr: successor of #4177

r10s
r10s approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@r10s r10s left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i cannot tell too much about the rust internals, but it lgtm at a first glance.

i also think, we should get that in soon, so that it can be tested in practise with the next 1.35 test releases.

not sure about the CI failures

@flub flub mentioned this pull request Mar 20, 2023
Merged
@flub flub merged commit 35f50a8 into master Mar 20, 2023
@flub flub deleted the flub/backup-provider-pause-io branch March 20, 2023 18:57
flub added a commit that referenced this pull request Mar 21, 2023
@flub
ref(jsonrpc): Do not explicitly stop IO for provider
6325d80 
Since #4182 (35f50a8) we no longer
need to stop IO explicitly, so let's not do that as it makes things
simpler to understand.
@flub flub mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

@link2xt link2xt Awaiting requested review from link2xt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

is dc_stop_io() needed before dc_backup_provider_new() or not?
2 participants
@flub @r10s