Explicitly call Context::set_last_error in ffi #4195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a result extension trait to explicitly set the last error, which *should* be the default for the FFI. Currently not touching all APIs since that's potentially disruptive and we're close to a release. The logging story is messy, as described in the doc comment. We should further clean this up and tidy up these APIs so it's more obvious to people how to do the right thing.
This was referenced Mar 21, 2023
r10s
approved these changes
Mar 21, 2023
|
Nice 🎉! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a result extension trait to explicitly set the last error,
which should be the default for the FFI. Currently not touching all
APIs since that's potentially disruptive and we're close to a release.
The logging story is messy, as described in the doc comment. We
should further clean this up and tidy up these APIs so it's more
obvious to people how to do the right thing.
This is an alternative to #4187, hopefully addressing @Hocuri's
fears. I believe these APIs need further cleaning up as described,
but let's leave that for after the release.
Closes #4186, #4178
Since this now does not affect anything other than core-internal:
#skip-changelog