introduce UIChatListItemChanged event #4475
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why? because desktop currently fetches the chatlist multiple times, even though it just needs the chatlistitem for one chat Note: @r10s was worried before that exposing the method to get a single updated chatlistitem could lead to race conditions where the chatlist item is newer than the chatlist order. But I don't think this will change anything for desktop besides making it a little faster. (because currently desktop fetches the whole chatlist instead of just the entry it needs when an entry updates)
there still are bugs in the sql query of get_chatlistitem_for_chat, but other than that already works fine in desktop
and change return type to `Option<MsgId>`
also run cargo fmt
also emit an UIChatListItemChanged for the archive link pseudo item when marking it as read
|
this is replaced by the rebased version in #4476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_chatlistitem_for_chattoget_last_message_for_chat