fix: reduce the scope of the last_full_folder_scan lock in scan_folders #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is likely no bug, I was just looking at all the locks while trying to find the reason for #6477 |
adbenitez
approved these changes
May 25, 2025
Hocuri
approved these changes
May 28, 2025
This makes it easier to ensure that holding this lock does not result in deadlocks.
link2xt
force-pushed
the
link2xt/scan-folders-lock
branch
from
7a65541 to
89df953
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to ensure that holding this lock does not result in deadlocks.