fix: update "advanced-js" CLI template to match the TS version #1143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanjudis
force-pushed
the
fix-cli-onboarding-deprecation-warning
branch
from
10b6671 to
922c367
Compare
stefanjudis
commented
Sep 9, 2025
| } | ||
|
|
||
| setup(); | ||
| await setup() |
There was a problem hiding this comment.
This part is a bit "meh" because top-level await isn't supported in non-modules, but the functionality still works in Checkly (I assume everything's bundled anyways).
stefanjudis
force-pushed
the
fix-cli-onboarding-deprecation-warning
branch
from
922c367 to
a2e18a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Affected Components
Notes for the Reviewer
This PR pretty much mirrors the
advancedboilerplate and updates the oldadvanced-jsboilerplate. I changed all thetsreferences and migrated ESM to CommonJS to fit the existing convention.I tested the repo locally and looks good.