Skip to content

Drop support for PHP 5.5, 5.6, 7.0 and 7.1. Test against 7.4. #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

nickdnk
Copy link
Contributor

@nickdnk nickdnk commented Jun 11, 2020

It doesn't seem to pass. I don't know why though.

See the log here: https://travis-ci.com/github/nickdnk/php-redis-client/jobs/347759390

@nickdnk
Copy link
Contributor Author

nickdnk commented Jun 11, 2020

So I did a little reading. It seems that you'd have to update PHPUnit to a later version. I tried with 5.x, but it still didn't work, which lead me to sebastianbergmann/phpunit#3728

Perhaps it's time to release a 2.0 of this package with support for only PHP 7.2, 7.3 and 7.4? That would allow the latest version of PHP 8 to be used.

@nickdnk nickdnk marked this pull request as draft June 11, 2020 23:13
Dropped support for PHP 5.5, 5.6, 7.0 and 7.1
Upgraded to PHPUnit 8.*
Fixed Test namespace
@nickdnk nickdnk changed the title Test against PHP 7.4 Drop support for PHP 5.5, 5.6, 7.0 and 7.1. Test against 7.4. Jun 11, 2020
@nickdnk
Copy link
Contributor Author

nickdnk commented Jun 11, 2020

So I got it to work: https://travis-ci.com/github/nickdnk/php-redis-client

@cheprasov
Copy link
Owner

Hi @nickdnk Thanks a lot for your contribution, I work on it, and the RedisClient will stop support old PHP versions, and the client will be released for 7.4 and above.

Also, I am sorry, but I can not merge your PR because described work requires a lot of refactoring, optimisation and changes, be patient patient.

@nickdnk
Copy link
Contributor Author

nickdnk commented Jun 20, 2020

Okay. Cool. I am using it with PHP 7.4 and it works fine (for me) so far. I will be patient :)

@nickdnk
Copy link
Contributor Author

nickdnk commented Oct 4, 2021

Hey @cheprasov

Any news here? I am slowly planning migration to PHP 8 and I really like this library.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants