Skip to content

PHP7 Compatibility - remove preg_match with /e modifier #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

PHP7 Compatibility - remove preg_match with /e modifier #36

wants to merge 1 commit into from

Conversation

PhilETaylor
Copy link

This PR fixes PHP7 compatibility - I doubt anyone will merge it back to the upstream repo as that looks almost abandoned - however here it is for those of you like me that this broke for when they started using PHP7

@aedelstein
Copy link

If the regex '# ( +)|^ #is' hits on the |^, $m[1] will be undefined.

@chrisboulton
Copy link
Owner

Hi - please also see #42 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants