Timestamp data type #230
Open
Timestamp data type #230
+113
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tobyhede
commented
May 15, 2025
tobyhede
commented
- adds handling for timestamp data type from_sql
- test to map timestamp
- add missing biguint to_sql implementation at no extra charge
yujiyokoo
approved these changes
May 16, 2025
| let client = connect_with_tls(PROXY).await; | ||
|
|
||
| let id = id(); | ||
| let encrypted_timestamp = "2000-10-01T17:30:00Z".parse::<DateTime<Utc>>().unwrap(); |
There was a problem hiding this comment.
Would it be a good idea to add another test case set in a different time zone than UTC?
| @@ -47,8 +49,10 @@ fn binary_to_sql(plaintext: &Plaintext) -> Result<BytesMut, Error> { | |||
| Plaintext::Utf8Str(x) => x.to_sql_checked(&Type::TEXT, &mut bytes), | |||
| Plaintext::JsonB(x) => x.to_sql_checked(&Type::JSONB, &mut bytes), | |||
| Plaintext::Decimal(x) => x.to_sql_checked(&Type::NUMERIC, &mut bytes), | |||
| // TODO: Implement these | |||
| Plaintext::BigUInt(_x) => unimplemented!(), | |||
| Plaintext::BigUInt(x) => { | |||
There was a problem hiding this comment.
Was this needed here for timestamp, or is this a separate implementation? If so, is this covered with a test case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.