MAINT Configure Windows CI using AppVeyor

CHANGELOG.md

@@ -11,6 +11,7 @@ This project adheres to [Semantic Versioning](http://semver.org/).
 ### Added
 - Added instructions in the README for adding an API key to a Windows 10
   environment
+- Configured Windows CI using AppVeyor. (#258)
 
 ### Changed
 - Coalesced `README.rst` and `index.rst`. (#254)

appveyor.yml

@@ -0,0 +1,39 @@
+build: false  # Not a .NET project
+
+
+environment:
+  # For python environments: https://www.appveyor.com/docs/build-environment/#python
+  matrix:
+    - PYTHON: "C:\\Python27-x64"
+      PYTHON_VERSION: "2.7.15"
+      PYTHON_ARCH: "64"
+
+    - PYTHON: "C:\\Python34-x64"
+      PYTHON_VERSION: "3.4.4"
+      PYTHON_ARCH: "64"
+
+    - PYTHON: "C:\\Python35-x64"
+      PYTHON_VERSION: "3.5.3"
+      PYTHON_ARCH: "64"
+
+    - PYTHON: "C:\\Python36-x64"
+      PYTHON_VERSION: "3.6.5"
+      PYTHON_ARCH: "64"
+
+  # Environmental variables
+  CIVIS_API_KEY: "FOOBAR"
+
+
+init:
+  - "ECHO %PYTHON% %PYTHON_VERSION% %PYTHON_ARCH%"
+
+
+install:
+  - "%PYTHON%\\python.exe -m pip install --upgrade pip setuptools"
+  - "%PYTHON%\\python.exe -m pip install -r dev-requirements.txt"
+  - "%PYTHON%\\python.exe -m pip install -e ."
+
+
+test_script:
+  - "%PYTHON%\\Scripts\\flake8.exe civis"
+  - "%PYTHON%\\Scripts\\pytest.exe -rxXs --cov civis"

civis/ml/tests/test_model.py

@@ -5,7 +5,6 @@
 import json
 import os
 import pickle
-import tempfile
 
 import joblib
 try:
@@ -32,7 +31,7 @@
 from civis import APIClient
 from civis._utils import camel_to_snake
 from civis.base import CivisAPIError, CivisJobFailure
-from civis.compat import mock, FileNotFoundError
+from civis.compat import mock, FileNotFoundError, TemporaryDirectory
 from civis.response import Response
 import pytest
 
@@ -143,8 +142,8 @@ def foo(arg):
 
 @mock.patch.object(_model.cio, 'file_to_civis', return_value=-11)
 def test_stash_local_data_from_file(mock_file):
-    with tempfile.NamedTemporaryFile() as tempfname:
-        fname = tempfname.name
+    with TemporaryDirectory() as temp_dir:
+        fname = os.path.join(temp_dir, 'tempfile')
         with open(fname, 'wt') as _fout:
             _fout.write("a,b,c\n1,2,3\n")
 

civis/tests/test_io.py

@@ -2,7 +2,6 @@
 import json
 import os
 from six import StringIO, BytesIO
-import tempfile
 import zipfile
 
 import pytest
@@ -85,10 +84,11 @@ def setup_class(cls, *mocks):
             res.result()  # block
 
             # create an export to check get_url. also tests export_csv
-            with tempfile.NamedTemporaryFile() as tmp:
+            with TemporaryDirectory() as temp_dir:
+                fname = os.path.join(temp_dir, 'tempfile')
                 sql = "SELECT * FROM scratch.api_client_test_fixture"
                 database = 'redshift-general'
-                result = civis.io.civis_to_csv(tmp.name, sql, database,
+                result = civis.io.civis_to_csv(fname, sql, database,
                                                polling_interval=POLL_INTERVAL)
                 result = result.result()
                 cls.export_url = result['output'][0]['path']
@@ -98,9 +98,11 @@ def setup_class(cls, *mocks):
 
     @mock.patch(api_import_str, return_value=civis_api_spec)
     def test_zip_member_to_civis(self, *mocks):
-        with tempfile.NamedTemporaryFile() as tmp:
-            with zipfile.ZipFile(tmp, 'w', zipfile.ZIP_DEFLATED) as zip_file:
-                zip_file.writestr(tmp.name, 'a,b,c\n1,2,3')
+        with TemporaryDirectory() as temp_dir:
+            fname = os.path.join(temp_dir, 'tempfile')
+            with zipfile.ZipFile(fname, 'w', zipfile.ZIP_DEFLATED) as zip_file:
+                archive_name = 'archive_name'
+                zip_file.writestr(archive_name, 'a,b,c\n1,2,3')
                 zip_member = zip_file.namelist()[0]
                 with zip_file.open(zip_member) as zip_member_buf:
                     result = civis.io.file_to_civis(zip_member_buf, zip_member)
@@ -129,11 +131,12 @@ def test_bytes_file_to_civis(self, *mocks):
     def test_large_file_to_civis(self, *mocks):
         curr_size = civis.io._files.MIN_MULTIPART_SIZE
         civis.io._files.MIN_MULTIPART_SIZE = 1
-        with tempfile.NamedTemporaryFile() as tmp:
-            tmp.write(b'a,b,c\n1,2,3')
-            tmp.flush()
-            tmp.seek(0)
-            result = civis.io.file_to_civis(tmp, tmp.name)
+        with TemporaryDirectory() as temp_dir:
+            fname = os.path.join(temp_dir, 'tempfile')
+            with open(fname, 'w+b') as tmp:
+                tmp.write(b'a,b,c\n1,2,3')
+            with open(fname, 'r+b') as tmp:
+                result = civis.io.file_to_civis(tmp, fname)
 
             civis.io._files.MIN_MULTIPART_SIZE = curr_size
 
@@ -148,13 +151,14 @@ def test_civis_to_file(self, *mocks):
 
     @mock.patch(api_import_str, return_value=civis_api_spec)
     def test_csv_to_civis(self, *mocks):
-        with tempfile.NamedTemporaryFile() as tmp:
-            tmp.write(b'a,b,c\n1,2,3')
-            tmp.flush()
+        with TemporaryDirectory() as temp_dir:
+            fname = os.path.join(temp_dir, 'tempfile')
+            with open(fname, 'w+b') as tmp:
+                tmp.write(b'a,b,c\n1,2,3')
 
             table = "scratch.api_client_test_fixture"
             database = 'redshift-general'
-            result = civis.io.csv_to_civis(tmp.name, database, table,
+            result = civis.io.csv_to_civis(fname, database, table,
                                            existing_table_rows='truncate',
                                            polling_interval=POLL_INTERVAL)
             result = result.result()  # block until done
@@ -265,10 +269,11 @@ def test_get_sql_select(self, *mocks):
 
     def test_download_file(self, *mocks):
         expected = '"1","2","3"\n'
-        with tempfile.NamedTemporaryFile() as tmp:
-            civis.io._tables._download_file(self.export_url, tmp.name,
+        with TemporaryDirectory() as temp_dir:
+            fname = os.path.join(temp_dir, 'tempfile')
+            civis.io._tables._download_file(self.export_url, fname,
                                             b'', 'none')
-            with open(tmp.name, "r") as f:
+            with open(fname, "r") as f:
                 data = f.read()
         assert data == expected
 

civis/tests/test_polling.py

@@ -71,8 +71,8 @@ def test_poll_on_creation(self):
                                   poll_on_creation=False)
         pollable.done()  # Check status once to start the polling thread
         assert poller.call_count == 0
-        time.sleep(0.015)
-        assert poller.call_count == 1
+        time.sleep(0.02)
+        assert poller.call_count > 0
 
     def test_reset_polling_thread(self):
         pollable = PollableResult(

dev-requirements.txt

@@ -7,7 +7,7 @@ vcrpy>=1.11.0,<=1.11.99
 vcrpy-unittest==0.1.6
 sphinx_rtd_theme>=0.2.4,<1.0.0
 numpydoc>=0.7.0,<1.0.0
-feather-format
+feather-format; sys_platform != 'win32' or python_version >= '3.5'
 numpy
 pandas; python_version >= '3.5'
 pandas<0.21; python_version == '3.4'