-
Notifications
You must be signed in to change notification settings - Fork 26
MAINT Configure Windows CI using AppVeyor #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jacksonllee
wants to merge
20
commits into
civisanalytics:master
from
jacksonllee:set-up-windows-continuous-integration-2
Closed
MAINT Configure Windows CI using AppVeyor #260
jacksonllee
wants to merge
20
commits into
civisanalytics:master
from
jacksonllee:set-up-windows-continuous-integration-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
by checking just whether or not poller is called. Asserting a specific call count for a given sleep time is not practical, because of different execution/testing environments (Circle CI versus AppVeyor, for example).
Because polling_interval is 0.01, setting sleep time of 0.02s should (hopefully) be long enough to register at least 1 poller call.
feather-format depends on pyarrow, which does not have Windows packages for python version < 3.5. See https://arrow.apache.org/docs/python/install.html
The archive name is a member file inside a zip file. It'd seem more reasonable to have it different than the zip file name.
This is the same as #258. Creating this PR just to see if AppVeyor builds are triggered (which apparently are not...) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IT support has turned on AppVeyor for CI in Windows. This PR configures that, based on what we already have for Circle CI.
Resolves #10.