Upgrade angular to 1.5.x

[stefk]

Needs UI tests. Link to docker instance will be provided ASAP.

[stefk]

Here's the link: http://pr-658-1466002261.travis-build.claroline.net/claroline/

There might be an issue related to the angular upgrade in http://pr-658-1466002261.travis-build.claroline.net/claroline/admin/open/user_management#/users.

EDIT: fixed, new link below

[LaurentGruber]

I don't see te issue in user management, what's the problem ?

[stefk]

There are two js errors in the browser console. I didn't find any bug in the ui neither, but it can't be good, something may be broken somewhere...

[Elorfin]

@stefk : can you provide the JS errors please ?

[stefk]

You don't see them in the console when following the link above (I'm using chromium) ?

First:

commons-a6fe081….js:2 Error: [ui.select:transcluded] http://errors.angularjs.org/1.5.6/ui.select/transcluded?p0=Expected%201%20.ui-select-match%20but%20got%20'%7B0%7D'.&p1=0
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/claroline-distribution-main-core-user-management-a6fe081c27ef87edc567.js:2:19564
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/claroline-distribution-main-core-user-management-a6fe081c27ef87edc567.js:3:5752
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:29875
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:2:252
at d (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:30741)
at l (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:2:780)
at Object. (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/claroline-distribution-main-core-user-management-a6fe081c27ef87edc567.js:3:5455)
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:8699
at ia (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:2:9524)
at n (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:2:2025)
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:2:7434
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:2821
at m.$eval (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:10196)
at m.$digest (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:8742)
at m.$apply (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:10490)
at http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11132
at Object.invoke (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:21580)
at Ac.c (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11053)
at Ac (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11347)
at fe (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:10646)
at HTMLDocument. (http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:6:1018)
at i (http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:27065)
at Object.j.fireWith as resolveWith
at Function.n.extend.ready (http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:29621)
at HTMLDocument.J (http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:29806)

Second:

commons-a6fe081….js:2 TypeError: Cannot read property 'source' of undefined
at Array. (claroline-distribution-main-core-user-management-a6fe081….js:3)
at commons-a6fe081….js:5
at m.$digest (commons-a6fe081….js:3)
at m.$apply (commons-a6fe081….js:3)
at commons-a6fe081….js:1
at Object.invoke (commons-a6fe081….js:1)
at Ac.c (commons-a6fe081….js:1)
at Ac (commons-a6fe081….js:1)
at fe (commons-a6fe081….js:1)
at HTMLDocument. (commons-a6fe081….js:6)
at i (jquery.min.js:2)
at Object.j.fireWith as resolveWith
at Function.n.extend.ready (jquery.min.js:2)
at HTMLDocument.J (jquery.min.js:2)(anonymous function) @ commons-a6fe081….js:2

[Elorfin]

Just requested them for history / simplicity.

I don't get the same second error with Firefox.

Error: $select.parserResult is undefined
[226]/</</<.link/<@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/claroline-distribution-main-core-user-management-a6fe081c27ef87edc567.js:3:11379
Og</<@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:5:18478
uf/this.$get</m.prototype.$digest@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:8874
uf/this.$get</m.prototype.$apply@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:3:10488
Ac/c/<@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11130
h/<.invoke@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:21578
Ac/c@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11051
Ac@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:11347
fe@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:1:10646
@http://pr-658-1466002261.travis-build.claroline.net/claroline/dist/commons-a6fe081c27ef87edc567.js:6:1018
n.Callbacks/i@http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:27060
n.Callbacks/j.fireWith@http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:27828
.ready@http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:29619
J@http://pr-658-1466002261.travis-build.claroline.net/claroline/packages/jquery/dist/jquery.min.js:2:29804

[stefk]

@LaurentGruber, @Elorfin, the search box is broken (no filters, wrong results). Seems related to ui.select.

[stefk]

angular-ui/ui-select#1325

Fixed by upgrading ui-select (angular-ui/ui-select#1430).

[stefk]

New link: http://pr-658-1466581835.travis-build.claroline.net/claroline

[stefk]

New link: http://pr-658-1467983596.travis-build.claroline.net/claroline

[stefk]

When an item containing a date is added to the portfolio, the following exception is thrown on server side:

request.CRITICAL: Uncaught PHP Exception InvalidArgumentException: "" at /var/www/html/claroline/vendor/claroline/distribution/plugin/portfolio/Manager/WidgetsManager.php line 181 {"exception":"[object](InvalidArgumentException%28code: 0%29: at /var/www/html/claroline/vendor/claroline/distribution/plugin/portfolio/Manager/WidgetsManager.php:181)"} []

[pitrackster]

It seems that the problem pointed by @stefk is related to the portfolio bundle itself not angular...
see https://github.com/claroline/Distribution/issues/874

[LaurentGruber]

LGTM Yahoooooooo

[Elorfin]

LGTM