WIP: Option to disable service for systemd. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status of PR
WIP, as it is untested yet.
Problem
When provider is set to
systemd, robot_upstart doesn't start the installed systemd unit and instead it only shows a comment to start manually, which I find is nice. However, (I guess by placing a unit file under/lib/systemd/system?) that unit is already enabled. So when the next time OS is rebooted, the systemd service in question starts. Sometimes this is not desired. User might want to get a control on whether the service is enabled or not.Change in this PR
disableoption, with which set to true the systemd unit gets "installed" but disabled so the service won't start before it's explicitly enabled.Open question
upstart?