Skip to content

quick fix for pip 10 and python 2 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

leon0707
Copy link
Contributor

@leon0707 leon0707 commented Sep 5, 2018

fix #6

@leon0707 leon0707 changed the title quick fix for pip 10 quick fix for pip 10 and python 2 Sep 5, 2018
@leon0707
Copy link
Contributor Author

leon0707 commented Sep 5, 2018

@clemfromspace Hi, would you mind taking a look at the test?

@clemfromspace
Copy link
Owner

Hey @leon0707, thanks for the PR!

Just looked at the output from travis and found this error:

...
../../../virtualenv/python3.6.3/lib/python3.6/site-packages/twisted/internet/address.py:111: in UNIXAddress
    name = attr.ib(converter=attr.converters.optional(_asFilesystemBytes))
E   TypeError: attrib() got an unexpected keyword argument 'converter'

Looks somewhat similar to mozilla/coverage-crawler#140

Concerning the content of the PR, thanks a lot for the fix concerning pip 10 👍

As for the support of Python 2.*, it may need a lot of changes, since I used the "f" string interpolation, so the package is not currently compatible at all with Python 2 (here and in other places)

@clemfromspace
Copy link
Owner

@leon0707 I fixed the tests in #8 , please rebase your PR :)

@leon0707 leon0707 closed this Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install with pip in python 2.7
2 participants