Skip to content

Hotfix/0.0.4 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements/requirements-test.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,4 @@ pytest==3.4.0
coverage<4.4
pytest-cov==2.4.0
codeclimate-test-reporter==0.2.3
attrs>=17.4.0
2 changes: 1 addition & 1 deletion scrapy_selenium/middlewares.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ def process_request(self, request, spider):
"""Process a request using the selenium driver if applicable"""

if not isinstance(request, SeleniumRequest):
return request
return None

self.driver.get(request.url)

Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = scrapy-selenium
version = 0.0.3
version = 0.0.4
url = https://github.com/clemfromspace/scrapy-selenium
licence = DO WHAT THE FUCK YOU WANT TO PUBLIC LICENSE
description = Scrapy with selenium
Expand Down
9 changes: 4 additions & 5 deletions tests/test_middlewares.py
Original file line number Diff line number Diff line change
Expand Up @@ -69,17 +69,16 @@ def test_spider_closed_should_close_the_driver(self):

mocked_quit.assert_called_once()

def test_process_request_should_return_the_request_if_not_selenium_request(self):
"""Test that the ``process_request`` should return a request if not selenium request"""
def test_process_request_should_return_none_if_not_selenium_request(self):
"""Test that the ``process_request`` should return none if not selenium request"""

scrapy_request = Request(url='http://not-an-url')

self.assertEqual(
self.assertIsNone(
self.selenium_middleware.process_request(
request=scrapy_request,
spider=None
),
scrapy_request
)
)

def test_process_request_should_return_a_response_if_selenium_request(self):
Expand Down