-
Notifications
You must be signed in to change notification settings - Fork 346
fix(backend): Added missing types to create invitation #2268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 1df7e39 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@@ -8,6 +8,8 @@ type CreateParams = { | |||
emailAddress: string; | |||
redirectUrl?: string; | |||
publicMetadata?: UserPublicMetadata; | |||
delay?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see delay
mentioned in the BAPI docs and also can't find it (quick glance) in the source code. Where would that be coming from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a delay
param either but there is a notify?: boolean
instead.
ref: https://clerk.com/docs/reference/backend-api/tag/Invitations#operation/CreateInvitation!path=notify&t=request
Co-authored-by: Lennart <[email protected]>
…erkinc/javascript into roy/fix-create-invite-for-backend-sdk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This was a report from a customer @panteliselef. I advised that a fix would be coming but that they could use the BAPI directly until then. If backporting isn't hard (I don't recall the steps involved) then it would be nice for the customer. |
* fix(backend): Added missing types to create invitation * Update .changeset/fast-swans-smile.md Co-authored-by: Lennart <[email protected]> * fix(backend): Fixed typo --------- Co-authored-by: Lennart <[email protected]> (cherry picked from commit de6519d)
* fix(backend): Added missing types to create invitation * Update .changeset/fast-swans-smile.md Co-authored-by: Lennart <[email protected]> * fix(backend): Fixed typo --------- Co-authored-by: Lennart <[email protected]> (cherry picked from commit de6519d) Co-authored-by: Roy Anger <[email protected]>
Description
The https://clerk.com/docs/reference/backend-api/tag/Invitations#operation/CreateInvitation endpoint accepts delay and ignored_existing params, but the SDK does not (
javascript/packages/backend/src/api/endpoints/InvitationApi.ts
Line 7 in 6a33709
Fixes SDK-1051
Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change
Packages affected
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/clerk-expo
@clerk/fastify
gatsby-plugin-clerk
@clerk/localizations
@clerk/nextjs
@clerk/clerk-react
@clerk/remix
@clerk/clerk-sdk-node
@clerk/shared
@clerk/themes
@clerk/types
build/tooling/chore