Skip to content

fix(clerk-js): Fallback to FAPI error message for password pwned case (#2273) #2274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

desiprisg
Copy link
Contributor

@desiprisg desiprisg commented Dec 6, 2023

Description

Backport of #2273

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: facb628

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl changed the title Pwned error fallback backport fix(clerk-js): Fallback to FAPI error message for password pwned case (#2273) Dec 6, 2023
Copy link
Contributor

@dimkl dimkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's wait until we make all the changes in the original PR

@desiprisg desiprisg force-pushed the pwned_error_fallback_backport branch from 14a7e5f to 49c483a Compare December 6, 2023 12:34
@desiprisg desiprisg force-pushed the pwned_error_fallback_backport branch from 49c483a to facb628 Compare December 6, 2023 12:35
@dimkl dimkl added this pull request to the merge queue Dec 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 6, 2023
@dimkl dimkl added this pull request to the merge queue Dec 6, 2023
Merged via the queue into release/v4 with commit 6b59735 Dec 6, 2023
@dimkl dimkl deleted the pwned_error_fallback_backport branch December 6, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants