fix(backend,clerk-sdk-node): Resolve reported signature issues #2284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 548b994 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dimkl
commented
Dec 7, 2023
| @@ -8,7 +8,7 @@ import { loadApiEnv, loadClientEnv } from './utils'; | |||
| type ExtendedClerk = ReturnType<typeof _Clerk> & { | |||
| expressWithAuth: ReturnType<typeof createClerkExpressWithAuth>; | |||
| expressRequireAuth: ReturnType<typeof createClerkExpressRequireAuth>; | |||
| verifyToken: typeof _verifyToken; | |||
| verifyToken: (token: string, verifyOpts?: Parameters<typeof _verifyToken>[1]) => ReturnType<typeof _verifyToken>; | |||
There was a problem hiding this comment.
We will revisit this type as part of the changes in the v5 Project. This is a temporary fix to match the actual type.
desiprisg
approved these changes
Dec 7, 2023
panteliselef
approved these changes
Dec 7, 2023
dimkl
force-pushed
the
fix/reported-issues
branch
from
f3e83ef to
548b994
Compare
anagstef
approved these changes
Dec 7, 2023
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves
createUserfunction missingcreatedAtproperty #2281verifyTokenfunction has wrong signature #2280Checklist
npm testruns as expected.npm run buildruns as expected.Type of change
Packages affected
@clerk/backend@clerk/chrome-extension@clerk/clerk-js@clerk/clerk-expo@clerk/fastifygatsby-plugin-clerk@clerk/localizations@clerk/nextjs@clerk/clerk-react@clerk/remix@clerk/clerk-sdk-node@clerk/shared@clerk/themes@clerk/typesbuild/tooling/chore