Skip to content

chore(types,clerk-js,clerk-react): Drop Clerk.isReady() in favor of Clerk.loaded #2294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Dec 8, 2023

Description

Drop deprecated Clerk.isReady() in favor of Clerk.loaded.
Deprecation PR: #2293

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@dimkl dimkl self-assigned this Dec 8, 2023
Copy link

changeset-bot bot commented Dec 8, 2023

🦋 Changeset detected

Latest commit: d763cce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@clerk/clerk-js Major
@clerk/clerk-react Major
@clerk/types Major
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
gatsby-plugin-clerk Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/backend Patch
@clerk/fastify Patch
@clerk/clerk-sdk-node Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dimkl dimkl requested a review from octoper December 8, 2023 12:42
Copy link
Contributor

github-actions bot commented Dec 8, 2023

⚠️ Changes detected under the ClerkJS ui directory!

Don't forget to apply the same changes under the /ui.retheme directory:
packages/clerk-js/src/ui/** ➡️ packages/clerk-js/src/ui.retheme/**

Also, you may need to update the following files:

  • packages/localizations/src/en-US.retheme.ts
  • packages/localizations/src/index.retheme.ts
  • packages/types/src/appearance.retheme.ts
  • packages/types/src/clerk.retheme.ts
  • packages/types/src/index.retheme.ts
  • packages/types/src/localization.retheme.ts

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems we need to sync the changes for ui retheme.

@dimkl dimkl force-pushed the sdk-1036-drop-clerk-is-ready branch from 09d1fe7 to 5cabf54 Compare December 8, 2023 12:47
@dimkl dimkl requested a review from panteliselef December 8, 2023 12:47
@dimkl
Copy link
Contributor Author

dimkl commented Dec 8, 2023

@panteliselef done!

Copy link
Member

@panteliselef panteliselef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@dimkl dimkl enabled auto-merge December 8, 2023 12:51
@dimkl dimkl force-pushed the sdk-1036-drop-clerk-is-ready branch from 5cabf54 to d763cce Compare December 8, 2023 13:02
@dimkl dimkl added this pull request to the merge queue Dec 8, 2023
Merged via the queue into main with commit 7bffc47 Dec 8, 2023
@dimkl dimkl deleted the sdk-1036-drop-clerk-is-ready branch December 8, 2023 13:13
octoper pushed a commit that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants