Skip to content

fix(types): Avoid using ts-expect-error as it may fail for hosting apps #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

panteliselef
Copy link
Member

@panteliselef panteliselef commented Dec 11, 2023

Description

Solves the following error
image

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Packages affected

  • @clerk/backend
  • @clerk/chrome-extension
  • @clerk/clerk-js
  • @clerk/clerk-expo
  • @clerk/fastify
  • gatsby-plugin-clerk
  • @clerk/localizations
  • @clerk/nextjs
  • @clerk/clerk-react
  • @clerk/remix
  • @clerk/clerk-sdk-node
  • @clerk/shared
  • @clerk/themes
  • @clerk/types
  • build/tooling/chore

@panteliselef panteliselef requested a review from brkalow December 11, 2023 19:58
@panteliselef panteliselef self-assigned this Dec 11, 2023
Copy link

changeset-bot bot commented Dec 11, 2023

🦋 Changeset detected

Latest commit: 489b397

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@panteliselef panteliselef marked this pull request as ready for review December 11, 2023 20:01
@panteliselef panteliselef requested a review from a team December 11, 2023 20:03
@tmilewski tmilewski self-requested a review December 11, 2023 20:03
Copy link
Member

@brkalow brkalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@panteliselef panteliselef added this pull request to the merge queue Dec 11, 2023
Merged via the queue into main with commit 8e5cf6e Dec 11, 2023
@panteliselef panteliselef deleted the elef/fix-ts-expect-error-errors branch December 11, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants